rewire your lights, thats the most frequent problem i have, ive picked up lots of em and ive only had 1 that didnt work and i assume it was due to being left outside for most of its life.
also make sure the friction gear isnt "slipping" on the tire, ive got a few that give me troubles when the tires get wet just because of the angle and bracket position wasnt the best.
I had a couple off brand generators that wouldn't work, and I'm pretty sure one was even brand new. I ended up grabbing an old schwinn one because I knew that would work, and sure enough the lights came right on. I don't really see how they could stop working though.
...also, some, mostly taillights, have the ground connection in the clamp so the light needs to be mounted when checking it. If its that type, it will have a pointed screw that bores through the paint to make a connection.
Mine usually suddenly bind up suddenly, grinding the hell out of the sidewall. (Usually when going downhill at a reasonable speed at night on an unlit path somewhere in the sticks) :lol:
If you need to replace a generator and don't care if it's new, Walmart sells (or at least did) a generator light kit pretty cheap. Probably Bell brand.